Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split valkey.log and audit.log #261

Open
wants to merge 5 commits into
base: unstable
Choose a base branch
from

Conversation

LiiNen
Copy link
Contributor

@LiiNen LiiNen commented Apr 8, 2024

fix #260

what have been changed

  • Add config parameter "audit-logfile", usage is same as "logfile".
  • If "audit-logfile" is not empty and server.verbosity bigger than LL_VERBOSE, edit it as LL_VERBOSE.
  • If loglevel == LL_VERBOSE and server.verbosity == LL_VERBOSE, print it to "audit-logfile", not "logfile".

results

image

with valkey.conf as below:

# valkey.conf
logfile "./valkey.log"
audit-logfile "./audit.log"

Note

  • also wrote in [NEW] Splitting logfile for auditing #260
  • LL_DEBUG is not included in this change: not affected by this change.
    • It's intended because DEBUG is literally debug.
  • I would like to add more log levels: like splitting client connection logs with other verbose logs.
    • But this is a quite big change, so I didn't do it right now.
  • testfile is not ready cause it is just a concept of change. I'll work on it when this change is suitable for Valkey.

Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW] Splitting logfile for auditing
1 participant