Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a lua debugger bug that prevented use of 'server' for server.call invocations. #303

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Fixing a lua debugger bug that prevented use of 'server' for server.call invocations. #303

merged 2 commits into from
Apr 11, 2024

Commits on Apr 11, 2024

  1. fixing a lua debugger bug that prevented use of 'server' for server.c… 

    …all invocations.

* Tested it on local instance. This was originally part of valkey-io#288 but I am pushing this separately, so that we can easily merge it into the upcoming release.

```
lua debugger> server ping
<redis> ping
<reply> "+PONG"
lua debugger> redis ping
<redis> ping
<reply> "+PONG"
```

Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
    @parthpatel
    parthpatel committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    391fc3b View commit details
    Browse the repository at this point in the history

  2. Adding a test for the lua debugger bugfix. I don't understand TCL ver… 

    …y well but tried to implement as close to the patterns in the file as possible.

Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
    @parthpatel
    parthpatel committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    0893406 View commit details
    Browse the repository at this point in the history