New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replica redirect read&write to master in standalone mode #325
Open
soloestoy
wants to merge
4
commits into
valkey-io:unstable
Choose a base branch
from
soloestoy:replica-redirect
base: unstable
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8fce41e
replica redirect read&write to master in standalone mode
soloestoy 0d83765
change to REDIRECT
soloestoy 15163c9
Merge remote-tracking branch 'upstream/unstable' into replica-redirect
soloestoy be838bc
redirect by per client's capability
soloestoy File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"CAPA": { | ||
"summary": "A client claims its capability.", | ||
"complexity": "O(1)", | ||
"group": "connection", | ||
"since": "8.0.0", | ||
"arity": 3, | ||
"container": "CLIENT", | ||
"function": "clientCommand", | ||
"command_flags": [ | ||
"NOSCRIPT", | ||
"LOADING", | ||
"STALE" | ||
], | ||
"acl_categories": [ | ||
"CONNECTION" | ||
], | ||
"reply_schema": { | ||
"const": "OK" | ||
}, | ||
"arguments": [ | ||
{ | ||
"name": "capability", | ||
"type": "string" | ||
} | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
start_server {tags {needs:repl external:skip}} { | ||
start_server {} { | ||
set master_host [srv -1 host] | ||
set master_port [srv -1 port] | ||
|
||
r replicaof $master_host $master_port | ||
wait_for_condition 50 100 { | ||
[s 0 master_link_status] eq {up} | ||
} else { | ||
fail "Replicas not replicating from master" | ||
} | ||
|
||
test {replica allow read command by default} { | ||
r get foo | ||
} {} | ||
|
||
test {replica reply READONLY error for write command by default} { | ||
assert_error {READONLY*} {r set foo bar} | ||
} | ||
|
||
test {replica redirect read and write command after CLIENT CAPA REDIRECT} { | ||
r client capa redirect | ||
assert_error "REDIRECT $master_host:$master_port" {r set foo bar} | ||
assert_error "REDIRECT $master_host:$master_port" {r get foo} | ||
} | ||
|
||
test {non-data access commands are not redirected} { | ||
r ping | ||
} {PONG} | ||
|
||
test {replica allow read command in READONLY mode} { | ||
r readonly | ||
r get foo | ||
} {} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is -1 missing here? Keep the same format as MOVED and the client can reuse the parsing code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 is not part of MOVED.
MOVED is for a slot. REDIRECT is for all writes to the node, without slot. (Only cluster has slots.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, that's reasonable from valkey developer.