Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial PR outlining the governance for the project #345
Initial PR outlining the governance for the project #345
Changes from 6 commits
7ea75d4
c2227b0
13b381d
148719e
7bcb273
ffa6104
e0fd768
8fa8bbf
8cb7eae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the Valkey-io organization" just means the github org. It sounds like were defining our project in terms of whats under the github org, but it's rather the other way around. Can we write it in a different way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to tie the governance to specifically to github. Maybe I'll word it like:
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Or just keep it as is. It doesn't matter much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it "Valkey" or "Valkey-io" organization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's currently valkey-io organization. We're working on getting valkey though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused about the relationship between "maintainers" and "TSC". Although currently all TSC members are maintainers of the valkey core repo, but in the future these two groups may be changed separately. I think it would be better to describe them separately.
For example, we could use
MAINTAINERS.md
in the valkey repo to specifically detail the maintainers of the valkey repo. Additionally, introducing aTSC.md
directly under valkey-io (maybe a new governance or TSC repo) to clarify the composition of the TSC, highlighting their role in overseeing all projects under the valkey-io. This setup ensures that any future additions of maintainers for other clients or modules to the TSC wouldn't impact the list of maintainers for the valkey repo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least for now, practically maintainers = TSC. I think it makes the most sense to amend the document when that needs to change.