Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRC64 perf improvements from Redis patches #350

Merged
merged 10 commits into from May 1, 2024
Merged

CRC64 perf improvements from Redis patches #350

merged 10 commits into from May 1, 2024

Commits on Apr 23, 2024

  1. CRC64 perf improvements from Redis patches 

    * 53-73% faster on Xeon 2670 v0 @ 2.6ghz
* 2-2.5x faster on Core i3 8130U @ 2.2 ghz
* 1.6-2.46 bytes/cycle on i3 8130U
* likely >2x faster than crcspeed on newer CPUs with more resources than a 2012-era Xeon 2670
* crc64 combine function runs in <50 nanoseconds typical with vector + cache optimizations
  (~8 *microseconds* without vector optimizations, ~80 *microseconds without cache,
  the combination is extra effective)
* still single-threaded
* valkey-server test crc64 --help (requires `make distclean && make SERVER_TEST=yes`)

Signed-off-by: Josiah Carlson <josiah.carlson@gmail.com>
    @josiahcarlson
    josiahcarlson committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    4cfe03d View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Update README.md 

    Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Josiah Carlson <josiah.carlson@gmail.com>
    @josiahcarlson @zuiderkwast
    josiahcarlson and zuiderkwast committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    09cae3b View commit details
    Browse the repository at this point in the history

  2. Address review comments 

    Signed-off-by: Josiah Carlson <josiah.carlson@gmail.com>
    @josiahcarlson
    josiahcarlson committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    302cb2a View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. No docs per request 

    Signed-off-by: Josiah Carlson <josiah.carlson@gmail.com>
    @josiahcarlson
    josiahcarlson committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4139190 View commit details
    Browse the repository at this point in the history

  2. Fix assert typo 

    Signed-off-by: Josiah Carlson <josiah.carlson@gmail.com>
    @josiahcarlson
    josiahcarlson committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    be6afe6 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Make this work for Apple ARM 

    Signed-off-by: Josiah Carlson <josiah.carlson@gmail.com>
    @josiahcarlson
    josiahcarlson committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    75eb5dc View commit details
    Browse the repository at this point in the history

  2. The perils of not owning an ARM mac 

    Signed-off-by: Josiah Carlson <josiah.carlson@gmail.com>
    @josiahcarlson
    josiahcarlson committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9d5eac8 View commit details
    Browse the repository at this point in the history

  3. Update src/crccombine.c 

    Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
    @madolson
    madolson committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c9bca81 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Update src/crcspeed.c 

    Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
    @madolson
    madolson committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    866dca8 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Update src/crccombine.c 

    Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
    @madolson
    madolson committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f5c0509 View commit details
    Browse the repository at this point in the history