Modify mem_freed variable in evict.c and Update debug.c #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madolson
reviewed
Apr 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #376 +/- ##
=========================================
Coverage 68.37% 68.38%
=========================================
Files 108 108
Lines 61562 61562
=========================================
+ Hits 42096 42102 +6
+ Misses 19466 19460 -6
|
Signed-off-by: NAM UK KIM <namuk2004@naver.com> Updated evict.c Signed-off-by: NAM UK KIM <namuk2004@naver.com> Updated evict.c Signed-off-by: NAM UK KIM <namuk2004@naver.com>
madolson
approved these changes
Apr 30, 2024
PingXie
pushed a commit
to PingXie/valkey
that referenced
this pull request
May 2, 2024
Fix the mem_freed variable to be initialized with init. with this PR prevents the variable from acting unknowingly. Signed-off-by: NAM UK KIM <namuk2004@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the mem_freed variable to be initialized with init.
with this PR prevents the variable from acting unknownly.
evict.c 548 line
long long mem_freed = 0;
debug.c 2628 line
Also, the word "the" appears twice in the comment.
fixed it.