Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TLS.md configuration instructions #385

Merged
merged 2 commits into from May 3, 2024

Conversation

pshankinclarke
Copy link
Contributor

No description provided.

Signed-off-by: Parker Shankin-Clarke <parkerwsc1@gmail.com>
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.48%. Comparing base (19c4c64) to head (1176825).
Report is 16 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #385      +/-   ##
============================================
+ Coverage     68.35%   68.48%   +0.12%     
============================================
  Files           108      109       +1     
  Lines         61563    61671     +108     
============================================
+ Hits          42084    42233     +149     
+ Misses        19479    19438      -41     

see 22 files with indirect coverage changes

TLS.md Outdated Show resolved Hide resolved
@zuiderkwast
Copy link
Contributor

You need "Signed-off-by" on the suggestion too. You can do git rebase HEAD~1 --signoff and the force-push.

Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Parker Shankin-Clarke <parkerwsc1@gmail.com>
@zuiderkwast zuiderkwast merged commit 3b256a5 into valkey-io:unstable May 3, 2024
17 checks passed
@zuiderkwast
Copy link
Contributor

Thanks!

Actually, I think we should move this information to https://github.com/valkey-io/valkey-doc/blob/main/topics/encryption.md, where we have all the other documentation that will also be on the website (some time soon).

@zuiderkwast
Copy link
Contributor

zuiderkwast commented May 3, 2024

I see now that it's actually the same text that has diverged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants