Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the name of Apple's OS #386

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

brandondrew
Copy link

Apple stopped using the name "OS X" in 2016. (And they never used "OSX", without the space.)

Apple stopped using the name "OS X" in 2016.  (And they never used "OSX", without the space.)
@madolson
Copy link
Member

Makes sense to me. @brandondrew, would you mind signing off on your commits following our DCO requirements. You can see more here: https://github.com/valkey-io/valkey/pull/386/checks?check_run_id=24282435405

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.39%. Comparing base (19c4c64) to head (f1e6090).
Report is 2 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #386      +/-   ##
============================================
+ Coverage     68.35%   68.39%   +0.03%     
============================================
  Files           108      108              
  Lines         61563    61563              
============================================
+ Hits          42084    42105      +21     
+ Misses        19479    19458      -21     

see 13 files with indirect coverage changes

@stockholmux
Copy link
Contributor

Something mildly interesting that the PR number on this is 386 and it's about biggest platform that doesn't (currently) use an x86 architecture.

@madolson madolson added the pending-missing-dco For PRs that are blocked because they are missing a dco label Apr 27, 2024
@madolson
Copy link
Member

madolson commented May 1, 2024

@brandondrew Gentle reminder to update your commit by following the instructions on https://github.com/valkey-io/valkey/pull/386/checks?check_run_id=24282435405.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-missing-dco For PRs that are blocked because they are missing a dco
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants