Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed links and naming to valkey instead of redis #389

Merged
merged 9 commits into from May 2, 2024
Merged

Changed links and naming to valkey instead of redis #389

merged 9 commits into from May 2, 2024

Conversation

simkusr
Copy link
Contributor

@simkusr simkusr commented Apr 26, 2024 •
edited by zuiderkwast

This is a minor change where only naming and links now points properly to valkey.

Fixes #388

@simkusr
Changed links and naming to valkey instead of redis
6e0e245 
Signed-off-by: Rolandas Šimkus <rolandas@simkus.io>
@simkusr simkusr marked this pull request as draft April 26, 2024 11:11
@simkusr
updated manifesto to point from redis to valkey
b62ed63 
Signed-off-by: Rolandas Šimkus <rolandas@simkus.io>
@simkusr
updated naming convention
8523e13 
Signed-off-by: Rolandas Šimkus <rolandas@simkus.io>
@simkusr
as changes vere maid for script from redis-cli to valkey-cli did the
3d73848 
same in documentation

Signed-off-by: Rolandas Šimkus <rolandas@simkus.io>
@simkusr
Copy link
Contributor Author

simkusr commented Apr 26, 2024

non trivial naming conventions were changed from redis to valkey.

@simkusr simkusr marked this pull request as ready for review April 26, 2024 11:33
@simkusr
Copy link
Contributor Author

simkusr commented Apr 26, 2024

There are still left redis naming, but those ones require additional testing for scripts and more, it's different then this simple PR. With this PR I had an idea to rename from Redis to Valkey where the most we can see it, other require code changes so its out of this PR scope.

@simkusr simkusr mentioned this pull request Apr 26, 2024
Closed
madolson
madolson reviewed Apr 26, 2024
View reviewed changes
00-RELEASENOTES Outdated Show resolved Hide resolved
madolson
madolson reviewed Apr 26, 2024
View reviewed changes
COPYING Outdated Show resolved Hide resolved
madolson
madolson reviewed Apr 26, 2024
View reviewed changes
MANIFESTO Outdated Show resolved Hide resolved
madolson
madolson reviewed Apr 26, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
madolson
madolson reviewed Apr 26, 2024
View reviewed changes
deps/hiredis/COPYING Outdated Show resolved Hide resolved
updated changes after PR review, left Redis where it should be
2e628bb 
Signed-off-by: simkusr <rolandas.s@wilibox.com>
@simkusr
Copy link
Contributor Author

simkusr commented Apr 29, 2024

@madolson thanks for review, did the rollback and changes you mentioned, thanks again!

zuiderkwast
zuiderkwast reviewed May 1, 2024
View reviewed changes
deps/README.md Outdated Show resolved Hide resolved
zuiderkwast
zuiderkwast reviewed May 1, 2024
View reviewed changes
COPYING Outdated Show resolved Hide resolved
zuiderkwast
zuiderkwast reviewed May 1, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
zuiderkwast
zuiderkwast reviewed May 1, 2024
View reviewed changes
deps/README.md Outdated Show resolved Hide resolved
madolson
madolson reviewed May 1, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
simkusr and others added 4 commits May 2, 2024 12:42
@simkusr
Merge remote-tracking branch 'origin/unstable' into update_00-RELEASE…
84562f8 
…NOTES
@simkusr
revert from valkey to redis
0451bcc 
Signed-off-by: simkusr <rolandas@simkus.io>
@simkusr
reverted to redis as it is not official valkey client
65c341c 
Signed-off-by: simkusr <rolandas@simkus.io>
@zuiderkwast
Apply suggestions from code review
e606834 
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@codecov Codecov
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.43%. Comparing base (b0d5a0f) to head (e606834).
Report is 10 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable     #389      +/-   ##
============================================
+ Coverage     68.33%   68.43%   +0.09%     
============================================
  Files           108      109       +1     
  Lines         61563    61671     +108     
============================================
+ Hits          42072    42206     +134     
+ Misses        19491    19465      -26

see 20 files with indirect coverage changes

@zuiderkwast zuiderkwast added the rebranding Valkey is not Redis label May 2, 2024
@zuiderkwast zuiderkwast merged commit 68ca258 into valkey-io:unstable May 2, 2024
17 checks passed
PingXie pushed a commit to PingXie/valkey that referenced this pull request May 2, 2024
@simkusr @zuiderkwast @PingXie
Changed links and naming to valkey instead of redis (valkey-io#389)
758ecd8 
This is a minor change where only naming and links now points properly
to valkey.

Fixes valkey-io#388

---------

Signed-off-by: Rolandas Šimkus <rolandas@simkus.io>
Signed-off-by: simkusr <rolandas.s@wilibox.com>
Signed-off-by: simkusr <rolandas@simkus.io>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Co-authored-by: simkusr <rolandas.s@wilibox.com>
Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madolson madolson madolson left review comments

@zuiderkwast zuiderkwast zuiderkwast approved these changes

Assignees
No one assigned
Labels
rebranding Valkey is not Redis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

naming conventions and links should be changed from redis to valkey
3 participants
@simkusr @zuiderkwast @madolson