Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default syslog-ident from redis to valkey #390

Merged
merged 4 commits into from Apr 30, 2024
Merged

Change default syslog-ident from redis to valkey #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7262797
Rename syslog-ident from redis to valkey.
karthyuom Apr 26, 2024
8cfdb7e
Add backward compatibility for the syslog-ident conf.
karthyuom Apr 27, 2024
7c1a9ac
Fix memory leak issue, fix syslog-ident overriding, and added unit te…
karthyuom Apr 30, 2024
312a69e
revert compat config logic for syslog-ident, and relevant tests.
karthyuom Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/config.c
View file
Open in desktop
Expand Up @@ -3128,7 +3128,7 @@ standardConfig static_configs[] = {
createStringConfig("cluster-config-file", NULL, IMMUTABLE_CONFIG, ALLOW_EMPTY_STRING, server.cluster_configfile, "nodes.conf", NULL, NULL),
createStringConfig("cluster-announce-hostname", NULL, MODIFIABLE_CONFIG, EMPTY_STRING_IS_NULL, server.cluster_announce_hostname, NULL, isValidAnnouncedHostname, updateClusterHostname),
createStringConfig("cluster-announce-human-nodename", NULL, MODIFIABLE_CONFIG, EMPTY_STRING_IS_NULL, server.cluster_announce_human_nodename, NULL, isValidAnnouncedNodename, updateClusterHumanNodename),
createStringConfig("syslog-ident", NULL, IMMUTABLE_CONFIG, ALLOW_EMPTY_STRING, server.syslog_ident, "redis", NULL, NULL),
createStringConfig("syslog-ident", NULL, IMMUTABLE_CONFIG, ALLOW_EMPTY_STRING, server.syslog_ident, SERVER_NAME, NULL, NULL),
createStringConfig("dbfilename", NULL, MODIFIABLE_CONFIG | PROTECTED_CONFIG, ALLOW_EMPTY_STRING, server.rdb_filename, "dump.rdb", isValidDBfilename, NULL),
createStringConfig("appendfilename", NULL, IMMUTABLE_CONFIG, ALLOW_EMPTY_STRING, server.aof_filename, "appendonly.aof", isValidAOFfilename, NULL),
createStringConfig("appenddirname", NULL, IMMUTABLE_CONFIG, ALLOW_EMPTY_STRING, server.aof_dirname, "appendonlydir", isValidAOFdirname, NULL),
Expand Down
2 changes: 1 addition & 1 deletion valkey.conf
View file
Open in desktop
Expand Up @@ -357,7 +357,7 @@ logfile ""
# syslog-enabled no

# Specify the syslog identity.
# syslog-ident redis
# syslog-ident valkey

# Specify the syslog facility. Must be USER or between LOCAL0-LOCAL7.
# syslog-facility local0
Expand Down