Don't include config.h from serverassert.h #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #404 +/- ##
============================================
+ Coverage 68.33% 68.37% +0.03%
============================================
Files 108 108
Lines 61563 61563
============================================
+ Hits 42072 42096 +24
+ Misses 19491 19467 -24 |
madolson
reviewed
Apr 30, 2024
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
madolson
approved these changes
Apr 30, 2024
|
This PR number is 404 "File not found" 🤪 |
PingXie
pushed a commit
to PingXie/valkey
that referenced
this pull request
May 2, 2024
Serverassert is a drop-in replacement of assert. We use it even in code copied from other sources. To make these files usable outside of Valkey, it should be enough to replace the `serverassert.h` include with `<assert.h>`. Therefore, this file shouldn't have any dependencies to the rest of the valkey code. --------- Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serverassert is a drop-in replacement of assert. We use it even in code copied from other sources. To make these files usable outside of Valkey, it should be enough to replace the
serverassert.hinclude with<assert.h>. Therefore, this file shouldn't have any dependencies to the rest of the valkey code.This was mentioned in comments in #350.