[New] Migrate zmalloc.c unit tests to new test framework. #493
Conversation
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #493 +/- ##
=========================================
Coverage 69.80% 69.81%
=========================================
Files 109 109
Lines 61801 61801
=========================================
+ Hits 43141 43145 +4
+ Misses 18660 18656 -4
|
) This is the actual PR which is created to migrate all tests related to zmalloc into new test framework as part of the parent issue valkey-io#428. Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
) This is the actual PR which is created to migrate all tests related to zmalloc into new test framework as part of the parent issue valkey-io#428. Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com> Signed-off-by: adetunjii <adetunjithomas1@outlook.com>
) This is the actual PR which is created to migrate all tests related to zmalloc into new test framework as part of the parent issue valkey-io#428. Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com> Signed-off-by: adetunjii <adetunjithomas1@outlook.com>
) This is the actual PR which is created to migrate all tests related to zmalloc into new test framework as part of the parent issue valkey-io#428. Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
|
@karthyuom Would you mind taking a look at this daily run, https://github.com/valkey-io/valkey/actions/runs/9104302437/job/25027896513 and https://github.com/valkey-io/valkey/actions/runs/9104302437/job/25027896060. For some reason the address sanitizer variants are not happy about this test, but the normal CI is. |
|
@madolson I couldn't reproduce the above in my local test environment with the following command:
Also, the error Anyway, I will try to dive deeper to see where the problem is. |
) This is the actual PR which is created to migrate all tests related to zmalloc into new test framework as part of the parent issue valkey-io#428. Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
|
#516 Should fix it. I was only able to reproduce it running on ubuntu 22 with ASAN, it didn't error out on either of my mac development machines. |
) This is the actual PR which is created to migrate all tests related to zmalloc into new test framework as part of the parent issue valkey-io#428. Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
) This is the actual PR which is created to migrate all tests related to zmalloc into new test framework as part of the parent issue valkey-io#428. Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com> Signed-off-by: Samuel Adetunji <adetunjithomas1@outlook.com>
That is interesting. I tried the same fix with the help of daily CI in my forked repo, but still complaint about I just saw similar error even in the valkey's recent daily CI run: https://github.com/valkey-io/valkey/actions/runs/9183451888/job/25254186187. Looks like the issue is still not fixed(?) |
|
So, https://github.com/valkey-io/valkey/actions/runs/9183451888 was executed by me on a different commit that was missing the commit. https://github.com/valkey-io/valkey/actions/runs/9183169208 is the latest daily from unstable and it looks green. |
This is the actual PR which is created to migrate all tests related to zmalloc into new test framework as part of the parent issue #428.
Due to the conflict issue, the other PR #459 will be closed.
@madolson please review this and merge, as this accommodates all the intended changes.