Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trigger controller wait eventbus ready #577

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Mar 25, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Merging #577 (64323fc) into main (ee76217) will decrease coverage by 2.74%.
The diff coverage is 39.33%.

❗ Current head 64323fc differs from pull request most recent head 30814f8. Consider uploading reports for the commit 30814f8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
- Coverage   57.07%   54.33%   -2.74%     
==========================================
  Files         190      211      +21     
  Lines       15191    17161    +1970     
==========================================
+ Hits         8670     9325     +655     
- Misses       5884     7138    +1254     
- Partials      637      698      +61     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 35.93% <0.00%> (-16.70%) ⬇️
internal/controller/eventbus/block/selector.go 91.66% <ø> (-8.34%) ⬇️
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/gateway/proxy/auth.go 0.00% <0.00%> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/gateway/proxy/util.go 0.00% <0.00%> (ø)
internal/primitive/authentication/client.go 0.00% <0.00%> (ø)
internal/primitive/authorization/action.go 0.00% <0.00%> (ø)
internal/primitive/authorization/client.go 0.00% <0.00%> (ø)
... and 74 more

... and 46 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba347ae...30814f8. Read the comment docs.

Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant