Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Improve NixOS documentation #20497

Merged
merged 4 commits into from
May 29, 2024
Merged

Conversation

jpds
Copy link
Contributor

@jpds jpds commented May 15, 2024

Improved NixOS documentation by porting the config to JSON and also showing how to access an external service logs with additional group permissions.

@jpds jpds requested review from a team as code owners May 15, 2024 11:30
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small suggestions

@jpds jpds force-pushed the nixos-docs-improve branch 8 times, most recently from 12fe1fc to 4c125f1 Compare May 20, 2024 12:25
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jpds ! This looks like a good improvement in the way Vector is configured via Nix.

@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label May 20, 2024
@jszwedko jszwedko enabled auto-merge May 20, 2024 18:27
auto-merge was automatically disabled May 20, 2024 18:55

Head branch was pushed to by a user without write access

@jszwedko jszwedko enabled auto-merge May 20, 2024 19:00
auto-merge was automatically disabled May 20, 2024 20:07

Head branch was pushed to by a user without write access

@jszwedko jszwedko enabled auto-merge May 28, 2024 20:39
@jszwedko jszwedko added this pull request to the merge queue May 28, 2024
Merged via the queue into vectordotdev:master with commit 234b126 May 29, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants