Added Vulkan support for copying depth textures #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mellinoe
reviewed
Nov 4, 2022
| layerCount = layerCount, | ||
| mipLevel = srcMipLevel, | ||
| baseArrayLayer = srcBaseArrayLayer | ||
| }; | ||
|
|
||
| var dstAspect = (dstVkTexture.Usage & TextureUsage.DepthStencil) != 0 |
There was a problem hiding this comment.
I only question whether VkImageAspectFlags.Stencil is permitted to be passed here if the texture has a depth-only format. There is at least one other place in the code that treats it separately: https://github.com/mellinoe/veldrid/blob/eef8375169d1960a322f47f95e9b6ee8126e7b43/src/Veldrid/Vk/VkFramebuffer.cs#L202. I suspect a validation error might be emitted if you use the Stencil flag but the texture is depth-only.
This would be confirmed one way or the other by adding a test that exercises this.
mellinoe
requested changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vulkan backend currently does not support copying depth textures.