Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core,admin-ui): Allow update tracking code while fulfillment pen… #2170

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

denz93
Copy link
Contributor

@denz93 denz93 commented May 8, 2023

feat(core,admin-ui): Allow update tracking code while fulfillment pending

Related to #1828. This commit add a dialog for updating tracking code and expose an API

…ding

Related to vendure-ecommerce#1828. This commit add a dialog for updating tracking code and expose an API
@michaelbromley
Copy link
Member

Hi! Thanks for working on this. I have some feedback on the API that I would suggest:

Rather than updatePendingFulfillment, I think it makes more sense to just have updateFulfillment because this leaves open the possibility to update fulfillments in different states than Pending. Since the fulfillment process is configurable, it may well be that a process allows updating in other states. And in this case, the error result would be FulfillmentStateError, which is more general and also matches the existing error results like OrderStateError, RefundOrderStateError etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants