Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-ui): Add support for "payment method relation" custom field. Add "payment method data" service #2533

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Stefanyshyn
Copy link
Contributor

@Stefanyshyn Stefanyshyn commented Nov 19, 2023

Description

I have added a component to display the "payment method relation" custom field.
I also added the "payment method data" service. Part of the related logic has been moved from the "settings data" service to the new service.

Breaking changes

This PR doesn't include any breaking changes. It only extends the existing functionality

Screenshots

You can see what the "payment method relation" custom field looks like in the video below

payment-method-relation-custom-field.mp4

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

⚡ Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

netlify bot commented Nov 19, 2023

Deploy Preview for effervescent-donut-4977b2 canceled.

Name Link
🔨 Latest commit 813fc71
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/655b51b205ebe800082ee75e

@Stefanyshyn Stefanyshyn changed the title feat(admin-ui): Add support for payment method relation custom field. Add payment method service feat(admin-ui): Add support for "payment method relation" custom field. Add "payment method data" service Nov 19, 2023
@michaelbromley
Copy link
Member

Hi!

Thanks for this - it looks like it would be useful to ship in the admin ui. 2 points:

  • this is a new feature so should go in the minor branch.
  • the refactor you did with the data service could actually be a breaking change if someone is relying on dataService.settings.createPaymentMethod() etc. I would prefer you leave that part alone and just include the new component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants