-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor AI state update logic in Stock component #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated .env.example to be a bit more succinct.
@athrael-soju is attempting to deploy a commit to the Uncurated Tests Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address the warning from ESLint about missing dependencies in the
useEffect
and avoid the infinite loop issue when adding those dependencies, you can use auseCallback
for the logic that updates the state, ensuring that it only changes when necessary. This approach helps in managing dependencies more effectively and prevents unnecessary re-renders or infinite loops.The change introduces a
useCallback
that wraps the state update logic. The dependencies ofuseCallback
include all the variables and functions it usesaiState, id, setAIState, startHighlight, endHighlight, xToDate, format
. This ensures thatupdateAIState
only changes when one of its dependencies changes, preventing unnecessary executions.The useEffect hook then only needs to list
startHighlight, endHighlight
, andupdateAIState
as its dependencies. Since updateAIState is memoized and only changes when its dependencies change, it prevents the infinite loop issue while addressing the ESLint warning by correctly listing all dependencies.