Update nextjs app router guide to use ai/rsc #1189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyphilemon
force-pushed
the
jrmy/next-app
branch
from
fa74975
to
d42c6da
Compare
jaredpalmer
reviewed
Mar 19, 2024
| import OpenAI from 'openai'; | ||
| import { OpenAIStream, StreamingTextResponse } from 'ai'; | ||
| import { useState } from 'react'; | ||
| import { generate } from './actions'; |
There was a problem hiding this comment.
should we call this generate? given generateText coming?
jaredpalmer
reviewed
Mar 19, 2024
| import OpenAI from 'openai'; | ||
| import { OpenAIStream, StreamingTextResponse } from 'ai'; | ||
| import { useState } from 'react'; | ||
| import { generate } from './actions'; |
There was a problem hiding this comment.
should we call this generate? given generateText coming?
| // Creates a wrapped, changable value that can be streamed to the client. | ||
| const stream = createStreamableValue(''); | ||
|
|
||
| render({ |
There was a problem hiding this comment.
why not have const ui = render() and then return ui from the action?
jaredpalmer
requested changes
Mar 19, 2024
| </form> | ||
| </div> | ||
| ); | ||
| return { |
There was a problem hiding this comment.
Missing other APIs and or links to them.
|
|
||
| <div>{generation}</div> | ||
| </div> | ||
| ); | ||
| } | ||
| ``` | ||
|
|
||
| Note that using the Edge Runtime is optional but highly recommended due to [longer streaming timeouts on Vercel](https://vercel.com/docs/concepts/functions/edge-functions/limitations#maximum-initial-response-time), no cold starts, and lower latency. |
kevingyang
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.