New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export rsc util types #1536
base: main
Are you sure you want to change the base?
export rsc util types #1536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I think you'll have to edit the index file as well, otherwise the types won't be accessible.
Added those exports in index file |
@@ -40,7 +40,7 @@ type RenderTool<PARAMETERS extends z.ZodTypeAny = any> = { | |||
>; | |||
}; | |||
|
|||
type RenderText = Renderer< | |||
export type RenderText = Renderer< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shuding would renaming to TextRenderer
make sense before exporting this?
When creating reusable streaming ui tools, sometimes we have to seperate them in different files/modules that are not used directly within the
streamUI
function but they loses their typings. It would be nice to explicitly add types to those functions.