Make variant / image updates use useOptimistic and startTransition
#1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mhart
reviewed
May 8, 2024
| @@ -21,14 +22,21 @@ export function VariantSelector({ | |||
| const router = useRouter(); | |||
| const pathname = usePathname(); | |||
| const searchParams = useSearchParams(); | |||
| const [optimisticVariants, setOptimsticVariants] = useOptimistic(variants); | |||
There was a problem hiding this comment.
Nit
Suggested change
| const [optimisticVariants, setOptimsticVariants] = useOptimistic(variants); | |
| const [optimisticVariants, setOptimisticVariants] = useOptimistic(variants); |
mhart
reviewed
May 8, 2024
|
|
||
| const optionUrl = createUrl(pathname, optimisticOptions); | ||
|
|
||
| // Navigate without page reload |
There was a problem hiding this comment.
I'm not sure this comment's 100% accurate. It seems that the navigation can't complete without a full page render – at least in the sense that the search params are up-to-date, etc. While the UI is ready to interact with due to the useOptimistic hook, it's still waiting for the full page render before the search params update, so it's now open to race conditions for anything reading from the search params (eg, adding to cart)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CleanShot.2024-04-18.at.19.46.53.mp4