Turbopack: Add BeforeResolve plugin type
#8165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new plugin type for replacing resolution _before_ it occurs. This allows plugin authors to intercept requests for modules in place of the typical resolution strategy. This is used to replace `ImportMapping` replacers for `@next/font/local` in an upcoming Next.js PR
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
kwonoj
reviewed
May 17, 2024
| @@ -72,6 +72,7 @@ pub struct ResolveOptionsContext { | |||
| /// A list of plugins which get applied before (in the future) and after | |||
There was a problem hiding this comment.
probably need to adjust comment bit, also we may want to rename plugins in this case?
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
May 17, 2024
… show custom error message Depends on vercel/turbo#8165 This: - Creates and uses a `BeforeResolvePlugin` to handle requests to `next/font/local/target.css` instead of `ImportMapping` replacers - Returns a `ResolveResultItem::Error` which includes a custom `StyledString` describing the missing font file Test Plan: `TURBOPACK=1 pnpm test-dev test/e2e/app-dir/next-font/next-font.test.ts`
|
sokra
reviewed
May 17, 2024
| ) -> Result<Option<Vc<ResolveResult>>> { | ||
| for plugin in &options.await?.before_resolve_plugins { | ||
| if let Some(result) = *plugin | ||
| .before_resolve(lookup_path, reference_type.clone(), request) |
There was a problem hiding this comment.
That might have a negative performance effect, since it calls the plugin for every resolving in the application. So something like with the resolve plugins would be beneficial: before_resolve_condition
sokra
reviewed
May 17, 2024
| @@ -66,6 +67,7 @@ pub enum ModuleResolveResultItem { | |||
| OutputAsset(Vc<Box<dyn OutputAsset>>), | |||
| External(String, ExternalType), | |||
| Ignore, | |||
| Error(Vc<StyledString>), | |||
There was a problem hiding this comment.
Suggested change
| Error(Vc<StyledString>), | |
| RuntimeError(Vc<String>), |
I was thinking for this to lead to a runtime error during code generation.
There was a problem hiding this comment.
Shouldn't this be a build error -- we wouldn't want to produce something that is runnable if this is the case. I think that's what happens with Webpack.
sokra
reviewed
May 17, 2024
| @@ -2553,7 +2619,18 @@ pub async fn handle_resolve_error( | |||
| .cell() | |||
| .emit(); | |||
| } | |||
| result | |||
|
|
|||
| if let Some(error_string) = result.await?.get_first_error() { | |||
There was a problem hiding this comment.
I think it should not do that. It should just return the result even if that's a resolve result with runtime error.
The issue should be emitted earlier. E.g. in the before resolve plugin itself
kwonoj
approved these changes
May 20, 2024
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
May 20, 2024
… show custom error message (#65870) Depends on vercel/turbo#8165 This: - Creates and uses a `BeforeResolvePlugin` to handle requests to `next/font/local/target.css` instead of `ImportMapping` replacers - Returns a `ResolveResultItem::Error` which includes a custom `StyledString` describing the missing font file Test Plan: `TURBOPACK=1 pnpm test-dev test/e2e/app-dir/next-font/next-font.test.ts`
tknickman
pushed a commit
that referenced
this pull request
May 21, 2024
This adds a new plugin type for replacing resolution _before_ it occurs. This allows plugin authors to intercept requests for modules in place of the typical resolution strategy. This is used to replace `ImportMapping` replacers for `@next/font/local` in an upcoming Next.js PR
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
Jun 7, 2024
vercel/turbo#8165 introduced plugins that operate before resolving occurs, meaning that plugins like `InvalidImportResolvePlugin` which never use the initial resolve result and report issues can avoid that work. Test Plan: `TURBOPACK_DEV=1 TURBOPACK=1 pnpm test-dev test/development/acceptance-app/invalid-imports.test.ts`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new plugin type for replacing resolution before it occurs. This allows plugin authors to intercept requests for modules in place of the typical resolution strategy.
This is used to replace
ImportMappingreplacers for@next/font/localin an upcoming Next.js PR