Adding create_response method to class Router #1096
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
Router
does not have the methodcreate_response
attached to it, which is not consistent with the behavior of the main classNinjaAPI
. As such, I have added this method in the following pull request, and documented it under Routers in the documentation.I also changed the default HTTP status-code of the method
create_response
to 200 in bothRouter
andNinjaAPI
, so that the method can be called without error if the parameterstatus
is not defined.Other changes came from reformatting using
make lint
.After doing a coverage test on the app, 99.37% of the app is covered, however this 0.63% seems to be from a skipped test from pre-commit, and it seems that this modification is both stable and passing, both with custom app testing, and unit testing.