Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding create_response method to class Router #1096

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

atomtables
Copy link

The class Router does not have the method create_response attached to it, which is not consistent with the behavior of the main class NinjaAPI. As such, I have added this method in the following pull request, and documented it under Routers in the documentation.

I also changed the default HTTP status-code of the method create_response to 200 in both Router and NinjaAPI, so that the method can be called without error if the parameter status is not defined.

Other changes came from reformatting using make lint.

After doing a coverage test on the app, 99.37% of the app is covered, however this 0.63% seems to be from a skipped test from pre-commit, and it seems that this modification is both stable and passing, both with custom app testing, and unit testing.

@atomtables
Copy link
Author

@vitalik does this look good? just asking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant