Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Add OpenTelemetry support #4687

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

ronensc
Copy link
Contributor

@ronensc ronensc commented May 8, 2024

This PR adds basic support for OpenTelemetry distributed tracing.
It includes changes to enable tracing functionality and improve monitoring capabilities.

I've also added a markdown with print-screens to guide users how to use this feature. You can find it here

FIX #3789

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@ronensc ronensc changed the title Add OpenTelemetry support [Misc] Add OpenTelemetry support May 8, 2024
@rkooo567 rkooo567 self-assigned this May 8, 2024
@PRATIBHA-Moogi
Copy link

@rkooo567 can you please review this PR raised by Ronen. Thanks.

@rkooo567
Copy link
Collaborator

yep will do tmrw!

@ronensc ronensc force-pushed the otel branch 2 times, most recently from ace7fe2 to 899adef Compare May 27, 2024 15:04
@ronensc
Copy link
Contributor Author

ronensc commented May 27, 2024

Rebased to fix merge conflicts.

ttft = metrics.first_token_time - metrics.arrival_time
e2e_time = now - seq_group.metrics.arrival_time
# attribute names are based on
# https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/llm-spans.md

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adoption of otel llm semantic convetion, this is great!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. also do we have a holistic view of different observability metrics in vLLM?

I see another effort here: #5041

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this issue: #3616 (comment)

@ronensc
Copy link
Contributor Author

ronensc commented May 28, 2024

Added a commit to pass all unit tests.
Currently, a trace is created only for non-embedding requests because, for embedding requests, first_token_time isn't set, which is required for reporting TTFT. Additionally, sampling_params doesn't exist for embedding requests, so there is no point in reporting its metadata.

e2e_time = now - seq_group.metrics.arrival_time
# attribute names are based on
# https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/llm-spans.md
seq_span.set_attribute("gen_ai.response.model",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I suggest using the constants from https://github.com/traceloop/openllmetry/blob/main/packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv/ai/__init__.py
?
We keep them up to date with the decisions we're making in the otel semantic conventions working group

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion! I've added a dependency on opentelemetry-semantic-conventions-ai and extended SpanAttributes with the missing constants.

Copy link
Collaborator

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself looks good to me. My main concern is that we should probably not include this by default? This requires to setup Jaeger (or other tracing tools), and this seems pretty heavy requirements for every user.

That said, it'd require 3 changes.

  • remove the requirements from requirements-common.txt
  • init_trace should try importing it and becomes no-op when packages are not downloaded.
  • Fail the request if tracing is not enabled.

cc @simon-mo for thoughts!

return
arrival_time_nano_seconds = int(seq_group.metrics.arrival_time * 1e9)

with tracer.start_as_current_span(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ: what's the e2e overhead of this API? Can you measure and lmk for prompt length 512 output length 128?

@simon-mo
Copy link
Collaborator

It needs to be opt-in (i think it is already?), similar to TGI:

text-generation-inference is instrumented with distributed tracing using OpenTelemetry. You can use this feature by setting the address to an OTLP collector with the --otlp-endpoint argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add OpenTelemetry distributed tracing
7 participants