This repository has been archived by the owner on Nov 16, 2020. It is now read-only.
Update Knative version Readme #708
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neosab
reviewed
Oct 31, 2018
| @@ -90,6 +92,10 @@ Installing Dispatch depends on having a Kubernetes cluster with the Knative comp | |||
|
|
|||
| 4. Deploy via helm chart (if helm is not installed and initialized, do that first): | |||
| ```bash | |||
| cd charts/dispatch | |||
| helm dependency update | |||
| helm init | |||
There was a problem hiding this comment.
I would probably add a new optional step above for helm init and also mentions that tiller requires cluster admin privileges (refer the legacy installation steps)
There was a problem hiding this comment.
Nit: helm dep up instead of the verbose command
README.md
Outdated
| ``` | ||
|
|
||
| 2. Build and publish a dispatch image: | ||
| ```bash | ||
| PUSH_IMAGES=1 make images | ||
| ``` | ||
| > **NOTE**: You may need `docker login` before push |
There was a problem hiding this comment.
Nit : You may need to docker login before push
README.md
Outdated
| @@ -90,6 +92,10 @@ Installing Dispatch depends on having a Kubernetes cluster with the Knative comp | |||
|
|
|||
| 4. Deploy via helm chart (if helm is not installed and initialized, do that first): | |||
| ```bash | |||
| cd charts/dispatch | |||
There was a problem hiding this comment.
No need to cd
helm dep up ./charts/dispatch/
berndtj
reviewed
Nov 1, 2018
README.md
Outdated
| export CLUSTER_NAME=dispatch-knative | ||
| gcloud container clusters create -m n1-standard-4 --cluster-version ${K8S_VERSION} ${CLUSTER_NAME} | ||
| gcloud container clusters get-credentials ${CLUSTER_NAME} | ||
| gcloud container clusters create -m n1-standard-4 --cluster-version ${K8S_VERSION} ${CLUSTER_NAME} --zone us-west1-c |
There was a problem hiding this comment.
Maybe make the zone an env var too?
README.md
Outdated
| ```bash | ||
| cat << EOF > config.json | ||
| { | ||
| "current": "${RELEASE_NAME}", | ||
| "contexts": { | ||
| "${RELEASE_NAME}": { | ||
| "host": "$(kubectl -n ${DISPATCH_NAMESPACE} get service ${RELEASE_NAME}-nginx-ingress-controller -o json | jq -r .status.loadBalancer.ingress[].ip)", | ||
| "host": "$(kubectl -n ${DISPATCH_NAMESPACE} get service ${RELEASE_NAME}-nginx-ingress-controller -o json | jq -r ".status.loadBalancer.ingress[].ip")", |
There was a problem hiding this comment.
Should these be single quotes?
There was a problem hiding this comment.
Both works, then single quotes seems better
berndtj
approved these changes
Nov 1, 2018
neosab
approved these changes
Nov 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.