This repository has been archived by the owner on Nov 16, 2020. It is now read-only.
Fix docker registry and minio endpoints #797
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Values for Dispatch helm chart use hard-coded values for docker registry and minio endpoints. The values.yaml should reflect that.
|
Looks appropriate to me. This recently popped up in running through note to install on cloud pks. I needed to adjust the values.yaml directly over generating it with this script |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values for Dispatch helm chart use hard-coded values for docker registry
and minio endpoints. The values.yaml should reflect that.