test(runtime-vapor): api lifecycle hooks #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size ReportBundles
Usages
|
Ubugeeei
commented
May 19, 2024
Comment on lines
2
to
5
| type DebuggerEvent, | ||
| ITERATE_KEY, | ||
| type InjectionKey, | ||
| type Ref, |
There was a problem hiding this comment.
It gets sorted automatically by lint-staged.
LittleSound
reviewed
May 21, 2024
Ubugeeei
force-pushed
the
ubugeeei/test/component-lifecycle
branch
from
12fc70d
to
a265416
Compare
|
Indeed. I changed everything to "it"! |
LittleSound
approved these changes
May 21, 2024
sxzz
approved these changes
May 26, 2024
sxzz
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #164
relates: feat(runtime-core): implement debug hook #183
Regarding the lifecycle hook, I wrote tests based on the cases in packages/runtime-core/tests/apiLifecycle.spec.ts, but there seem to be some points where the behavior is incorrect.
I added FIXME to the test cases and created an issue on #216.