-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): show progress during render, log duration for each task, use humanized format #3385
Open
zhangyx1998
wants to merge
13
commits into
vuejs:main
Choose a base branch
from
zhangyx1998:feat/log-duration-for-each-task
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(build): show progress during render, log duration for each task, use humanized format #3385
zhangyx1998
wants to merge
13
commits into
vuejs:main
from
zhangyx1998:feat/log-duration-for-each-task
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify log format, use dash instead of parenthesis
zhangyx1998
changed the title
feat(build): log duration for each task, use humanized format
feat(build): show progress during render, log duration for each task, use humanized format
Dec 28, 2023
zhangyx1998
added a commit
to zhangyx1998/vitepress
that referenced
this pull request
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the
task()
utility by logging the duration after completion of a task. In addition, the build completion message also prints human friendly durations.In addition,
finally
statement is used in task.ts to make the code more concise.This change will allow me to demonstrate the performance improvement in later pull requests regarding parallelisation.
Before:
After:
The latest commit implements the progress indicator - screen recording
closes #3384