Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ES-331): enhance sdk docs #7083

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(ES-331): enhance sdk docs #7083

wants to merge 1 commit into from

Conversation

Razz21
Copy link
Contributor

@Razz21 Razz21 commented Mar 19, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Razz21 Razz21 requested a review from a team as a code owner March 19, 2024 12:16
Copy link

changeset-bot bot commented Mar 19, 2024

⚠️ No Changeset found

Latest commit: fe0fe79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@WojtekTheWebDev
Copy link
Collaborator

@rohrig Changes added in #7075

- Nuxt app [link](https://github.com/vuestorefront/vue-storefront/tree/main/packages/storefront/packages/nuxt/__tests__/app)

::info
In the browser, `getRequestHeaders` will return an empty object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In unified, we have
image

One of the questions I've seen come up is: "How do I use getRequestHeaders with useSdk?
Can you please address this? Is it possible? Is it recommended? I see the comment now that says "In the browser, getRequestHeaders will return an empty object." Can we take this one step further and explain usage with useSdk, or if it's not recommended, why and what to do instead if a dev feels it's needed. πŸ™‚ Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants