New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add layer-wise filesystem information to the analysis json file #458
base: main
Are you sure you want to change the base?
Conversation
runtime/export/layer.go
Outdated
DigestID string `json:"digestId"` | ||
SizeBytes uint64 `json:"sizeBytes"` | ||
Command string `json:"command"` | ||
FileList []filetree.NodeData `json:"fileList"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of NodeData which shows the view information as well, should this be FileInfo instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes currently, the FileList
will contain the ViewInfo
, which can be seen in the testcase here- https://github.com/Akash-Nayak/dive/blob/f1783c55b3d7bc02d5e9cbb681d25044998375cc/runtime/export/export_test.go#L28.
Should I make the changes so that it only contains the FileInfo
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of NodeData which shows the view information as well, should this be FileInfo instead?
Hi @wagoodman, I have changed it from NodeData
to FileInfo
.
54ddae2
to
f1783c5
Compare
note: forced pushed to rebase the branch for CI updates / conflicts |
Originally PR #342