Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(sdk): build wheels on musllinux #7490

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

ci(sdk): build wheels on musllinux #7490

wants to merge 12 commits into from

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Apr 26, 2024

Description

Status: IT DOESN'T WORK
image

Problems:

  • Compiling nvml with cgo+musl fails, and we've been so far unable to force any linker (lld or gold) to not worry about unresolved symbols (that's how nvml is written...). Even tried zig, but it also has issues with musl.

  • Tried skipping nvidia monitoring completely, it builds successfully, but the repair wheel step fails:

Repairing wheel...
      + sh -c 'auditwheel repair --lib-sdir . -w /tmp/cibuildwheel/repaired_wheel /tmp/cibuildwheel/built_wheel/wandb-0.17.0rc4-py3-none-linux_x86_64.whl'
  INFO:auditwheel.main_repair:Repairing wandb-0.17.0rc4-py3-none-linux_x86_64.whl
  Traceback (most recent call last):
    File "/usr/local/bin/auditwheel", line 8, in <module>
      sys.exit(main())
    File "/opt/_internal/pipx/venvs/auditwheel/lib/python3.10/site-packages/auditwheel/main.py", line 54, in main
      rval = args.func(args, p)
    File "/opt/_internal/pipx/venvs/auditwheel/lib/python3.10/site-packages/auditwheel/main_repair.py", line 125, in execute
      wheel_abi = analyze_wheel_abi(wheel_policy, wheel_file, exclude)
    File "/opt/_internal/pipx/venvs/auditwheel/lib/python3.10/site-packages/auditwheel/wheel_abi.py", line 246, in analyze_wheel_abi
      ) = get_wheel_elfdata(wheel_policy, wheel_fn, exclude)
    File "/opt/_internal/pipx/venvs/auditwheel/lib/python3.10/site-packages/auditwheel/wheel_abi.py", line 87, in get_wheel_elfdata
      for key, value in elf_find_versioned_symbols(elf):
    File "/opt/_internal/pipx/venvs/auditwheel/lib/python3.10/site-packages/auditwheel/elfutils.py", line 50, in elf_find_versioned_symbols
      for verneed, verneed_iter in section.iter_versions():
  AttributeError: 'Section' object has no attribute 'iter_versions'
                                                              ✕ 3.04s
Error: Command ['sh', '-c', 'auditwheel repair --lib-sdir . -w /tmp/cibuildwheel/repaired_wheel /tmp/cibuildwheel/built_wheel/wandb-0.17.0rc4-py3-none-linux_x86_64.whl'] failed with code 1. 
  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

@dmitryduev dmitryduev requested a review from a team as a code owner April 26, 2024 18:35
@github-actions github-actions bot added the cc-ci label Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 74.92%. Comparing base (846c34d) to head (f28b8fb).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7490      +/-   ##
==========================================
+ Coverage   74.90%   74.92%   +0.02%     
==========================================
  Files         519      520       +1     
  Lines       54627    54627              
==========================================
+ Hits        40918    40930      +12     
+ Misses      13308    13299       -9     
+ Partials      401      398       -3     
Flag Coverage Δ
func 43.39% <ø> (+0.14%) ⬆️
system 62.93% <ø> (+0.02%) ⬆️
unit 55.29% <46.15%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/pkg/monitor/gpu_amd_noop.go 46.15% <ø> (ø)
core/pkg/monitor/gpu_nvidia.go 5.98% <ø> (ø)
core/pkg/monitor/gpu_nvidia_noop.go 46.15% <46.15%> (ø)

... and 16 files with indirect coverage changes

Copy link
Contributor

@timoffex timoffex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it all works!

.github/workflows/release-sdk.yml Outdated Show resolved Hide resolved
@dmitryduev dmitryduev marked this pull request as draft April 26, 2024 20:45
@github-actions github-actions bot added cc-ci and removed cc-ci labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants