Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Add directory-watching to 'watcher2' #7596

Merged

Conversation

timoffex
Copy link
Contributor

@timoffex timoffex commented May 8, 2024

Description

Adds WatchDir function to the watcher2 package, making watcher redundant. I will delete watcher after removing references in tb.go.

Created using spr 1.3.5
@timoffex timoffex requested a review from a team as a code owner May 8, 2024 13:24
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 75.79%. Comparing base (5612829) to head (4a74de4).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7596      +/-   ##
==========================================
+ Coverage   75.76%   75.79%   +0.03%     
==========================================
  Files         502      502              
  Lines       54003    54016      +13     
==========================================
+ Hits        40914    40944      +30     
+ Misses      12676    12659      -17     
  Partials      413      413              
Flag Coverage Δ
func 41.17% <ø> (+0.04%) ⬆️
system 63.35% <20.00%> (-0.02%) ⬇️
unit 56.39% <63.15%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/internal/watcher2/impl.go 78.65% <100.00%> (+6.36%) ⬆️
core/internal/watcher2/watcher2.go 100.00% <ø> (ø)
core/internal/watcher2test/watcher2test.go 52.94% <22.22%> (-10.03%) ⬇️

... and 6 files with indirect coverage changes

Created using spr 1.3.5
@timoffex timoffex merged commit 4208d23 into main May 10, 2024
8 of 31 checks passed
@timoffex timoffex deleted the spr/timoffex/chorecore-add-directory-watching-to-watcher2 branch May 10, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants