Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Remove references to watcher and delete it #7599

Conversation

timoffex
Copy link
Contributor

@timoffex timoffex commented May 8, 2024

Description

Finishes replacing watcher by watcher2.

Created using spr 1.3.5
@timoffex timoffex requested a review from a team as a code owner May 8, 2024 16:50
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 16.27907% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 75.82%. Comparing base (f6ca1ac) to head (fe14225).

Additional details and impacted files

Impacted file tree graph

@@                                              Coverage Diff                                              @@
##           spr/timoffex/main.refactorcore-remove-references-to-watcher-and-delete-it    #7599      +/-   ##
=============================================================================================================
+ Coverage                                                                      75.78%   75.82%   +0.03%     
=============================================================================================================
  Files                                                                            502      499       -3     
  Lines                                                                          54016    53900     -116     
=============================================================================================================
- Hits                                                                           40938    40870      -68     
+ Misses                                                                         12663    12628      -35     
+ Partials                                                                         415      402      -13     
Flag Coverage Δ
func 41.18% <ø> (ø)
system 63.48% <16.27%> (+0.12%) ⬆️
unit 56.38% <13.95%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/internal/runfiles/uploader.go 78.94% <ø> (-0.13%) ⬇️
core/pkg/server/sender.go 70.94% <100.00%> (+0.07%) ⬆️
core/pkg/server/stream.go 97.02% <100.00%> (-0.02%) ⬇️
core/pkg/server/stream_init.go 94.80% <100.00%> (ø)
core/pkg/server/tb.go 22.41% <0.00%> (+1.10%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Contributor

@kptkin kptkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. will you be renaming watcher2 to watcher (or some other name that doesn't have the 2 suffix :))?

Created using spr 1.3.5

[skip ci]
Created using spr 1.3.5
@timoffex timoffex changed the base branch from spr/timoffex/main.refactorcore-remove-references-to-watcher-and-delete-it to main May 10, 2024 07:43
@timoffex timoffex merged commit 865a816 into main May 10, 2024
25 of 33 checks passed
@timoffex timoffex deleted the spr/timoffex/refactorcore-remove-references-to-watcher-and-delete-it branch May 10, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants