refactor: Update TimeToFloat64/TimeFromFloat64 functions, cover case … #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time is empty and unittest
wcharczuk
approved these changes
Dec 8, 2023
It's not worth comparing to what you are contributing to the community. Pls keep it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i lov the lib, its clear documentation. I found a solution for myself thanks to your detailed example. However, during the usage, I encountered situations that required handling empty values, so I added some logic to handle them, ensuring that I provided unit tests for both TimeToFloat647/TimeFromFloat64 functions.
Please let me know your thoughts,
Thanks for the good work,