Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ number validation is now available in type integer and float #541

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Junsang-Mun
Copy link

@Junsang-Mun Junsang-Mun commented Apr 13, 2022

Add feature #537

This feature can be used by adding second argument integer and float.

@justin-schroeder
Copy link
Member

Thanks for the PR. what about the edge case:

const num = "1.0"
1 % num === 0

Technically its still a float, but would evaluate as false

@Junsang-Mun
Copy link
Author

Thanks for let me know the edge cases Justin!
I wrote a few line of code which covers edge case.

Now 2.0 or 342.000 or something like that is treated as both integer and float.

@TudorPetrariu
Copy link

Any updates on this ? It would be a very nice addition and expected as well !

@Junsang-Mun
Copy link
Author

Actually I don't know why this feature isn't merged or rejected, but just... just here. @justin-schroeder is there any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants