Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose moving to node v20.12.2 in docs due to errors when testing #2005

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nathanwilk7
Copy link
Contributor

What's being changed:

Propose moving to suggesting node v20.12.2 because of a package error when running on v19.9.0 just now (on an arm64 macbook).

Also removes node from nvm install node 19.9.0 because nvm was ignoring the version when I ran this.

Type of change:

  • README

How Has This Been Tested?

  • Github action – automated build completed without errors
  • Local build - the site works as expected when running yarn start

Ran yarn build locally

Copy link
Contributor Author

@nathanwilk7 nathanwilk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other places in this repo like CI/CD/testing the default node version should be bumped from 19 to 20? Also left some comments in the PR

`weaviate.io` project dependencies.

```
nvm install node 19.9.0
nvm use 19.9.0
nvm install 20.12.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous behavior

nvm install node 19.9.0
v22.0.0 is already installed.

New behavior:

nvm install 20.12.2     
v20.12.2 is already installed.

note

nvm --version
0.39.5

nvm install node 19.9.0
nvm use 19.9.0
nvm install 20.12.2
nvm use 20.12.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using node v19.9.0, got:

nvm use 19.9.0
yarn install

yarn install v1.22.22
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
warning Resolution field "eta@1.13.0" is incompatible with requested version "eta@^2.0.0"
warning Resolution field "eta@1.13.0" is incompatible with requested version "eta@^2.0.0"
warning Resolution field "eta@1.13.0" is incompatible with requested version "eta@^2.0.0"
[3/5] 🚚  Fetching packages...
error nanoid@5.0.7: The engine "node" is incompatible with this module. Expected version "^18 || >=20". Got "19.9.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@daveatweaviate
Copy link
Contributor

@databyjp I think @nathanwilk7 is running into the same thing I did when I set up locally. Our tool chain is aging and we're starting to hit compatibility problems. Let's talk to @sebawita about updating. I think you two have a better idea about what's involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants