Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAFT: support back RF scale increase #4856

Merged
merged 10 commits into from
May 14, 2024
Merged

Conversation

moogacs
Copy link
Contributor

@moogacs moogacs commented May 6, 2024

What's being changed:

this PR :

links : chaos pipeline for activate and deactivate tenants

PR #4913

  • shards reinit method called initNonVector on nil class, therefore shard's store had no access to props buckets (no bucket for title found errors)
  • db update called after class was updated did not change Index::Config replication factor, so replicationEnabled method still returned false - making coordinator node do not propagating changes to replicas, only to itself

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@moogacs moogacs changed the title RAFT: support back RF scale+/- RAFT: support back RF scale increase May 6, 2024
@moogacs moogacs force-pushed the support-raft-rf-scale branch 2 times, most recently from 01953ad to 301554f Compare May 6, 2024 13:49
@moogacs moogacs changed the base branch from main to stable/v1.25 May 6, 2024 14:24
@moogacs moogacs force-pushed the support-raft-rf-scale branch 4 times, most recently from dcb3ce9 to 9d54f56 Compare May 6, 2024 14:53
@moogacs moogacs marked this pull request as ready for review May 6, 2024 15:45
@moogacs moogacs force-pushed the support-raft-rf-scale branch 2 times, most recently from fc4a943 to 654e672 Compare May 7, 2024 08:33
@aliszka aliszka force-pushed the support-raft-rf-scale branch 3 times, most recently from 6ce95ca to c31dcea Compare May 9, 2024 09:10
@aliszka aliszka force-pushed the support-raft-rf-scale branch 2 times, most recently from 2c654ab to c810c26 Compare May 13, 2024 16:11
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.4% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@reyreaud-l reyreaud-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See the non blockers if you want to change it

@moogacs moogacs merged commit e902c0f into stable/v1.25 May 14, 2024
42 checks passed
@moogacs moogacs deleted the support-raft-rf-scale branch May 14, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants