Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fluid container layout #3172

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

neatbyte-vnobis
Copy link
Collaborator

Changes

Implements issue "Add fluid container layout".

How Has This Been Tested?

Manual

Documentation

None

@SvenAlHamad
Copy link
Contributor

@neatbyte-vnobis - I've tested this one, but I don't really understand how it works. I see the cell has a toggle saying absolute positioning, but when I toggle that the cell just collapses. How do I actually position something?

@neatbyte-vnobis
Copy link
Collaborator Author

@neatbyte-vnobis - I've tested this one, but I don't really understand how it works. I see the cell has a toggle saying absolute positioning, but when I toggle that the cell just collapses. How do I actually position something?

After toggling "Absolute positioning" all elements inside cell become absolute positioned, that is why cell looks "collapsed". To make it look better you can set grid height some value in px.
Then you can change position of elements inside cell by selecting element and changing values under the "Position" tab.

@SvenAlHamad
Copy link
Contributor

I see, I missed the "Position" property in the sidebar. To improve the UX, can we do a few things:

  1. When a cell is set to "absolute" positioning, set a fixed height on the Grid element to 200px, only if the current height on the grid is not defined in "px".
  2. When we place an element inside an absolutely positioned cell, set the width of that element's container to "auto". So that it doesn't go outside the borders of the cell element to avoid situations as in this example:

CleanShot 2023-04-17 at 11 51 43@2x

@neatbyte-vnobis
Copy link
Collaborator Author

@SvenAlHamad @adrians5j
Any updates on this PR?
Maybe it worth to merge latest next into it and retest it

@neatbyte-vnobis
Copy link
Collaborator Author

@SvenAlHamad Is this feature still relevant? Should we resolve conflicts and retest it, or close this PR?

@SvenAlHamad
Copy link
Contributor

It's still relevant, but we'll de-prioritize this one for now until we have more time to think about the approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants