fix: fix inconsistent pb element save-behavior in editor #3540
Conversation
neatbyte-vnobis
force-pushed
the
neatbyte/pb-element-save-inconsistency
branch
from
31cf6ad
to
b28739a
Compare
packages/app-page-builder/src/editor/plugins/elementSettings/action/ActionSettings.tsx
Outdated
Show resolved
Hide resolved
| import { CreateElementEventActionArgsType } from "./types"; | ||
| import { EventActionCallable } from "~/types"; | ||
|
|
||
| export const createElementAction: EventActionCallable<CreateElementEventActionArgsType> = () => { | ||
| return { | ||
| actions: [] | ||
| actions: [new UpdateDocumentActionEvent()] |
There was a problem hiding this comment.
Let's add a comment why this step please.
There was a problem hiding this comment.
Did some more investigation on this.
Currently, Page Builder does not send update document requests to API when an element is added to a page. However, based on my testing, some elements (such as Heading, Paragraph, Image, Button, Pages List and Form) do trigger a document update.
For instance, adding a button element triggers this updateSettings function, when added to the page. Elements utilizing the Lexical Editor (like Heading and Paragraph) are triggering this onChange function.
By adding new UpdateDocumentActionEvent() to the createElementAction we ensure the document is updated after adding a new element to the page. But since the elements mentioned already trigger a document update on their own, this addition now results in two separate API calls when they are added.
I've tried to fix this for the Button, but the fix didn't work as expected, so I reverted these Button changes.
packages/app-page-builder/src/editor/plugins/elements/button/index.tsx
Outdated
Show resolved
Hide resolved
|
@adrians5j Is this PR ready to be merged? |
Changes
Resolve issue: Inconsistent pb element save-behavior in editor.
image,embeds) on website.How Has This Been Tested?
Manual
Documentation
None