-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: drop IDB chunk store #2553
base: master
Are you sure you want to change the base?
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been removed or ignored. Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
I guess we can merge this once https://bugs.webkit.org/show_bug.cgi?id=254726 is resolved, since safari is probably the biggest block on this |
New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: hybrid-chunk-store@1.2.0 |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:
What changes did you make? (Give an overview)
Dropped hybrid chunk store, to use FSA chunk store directly, this drops IDB support.
Lets assume every1 updates their browsers, as all browsers since recently support OPFS https://caniuse.com/mdn-api_storagemanager_getdirectory putting us at 88% coverage.
actually safari doesn't support createWritable https://caniuse.com/mdn-api_filesystemfilehandle_createwritable so this is a 73% coverage :/ maybe lets leave this PR to sit for a while
FSA offers waaaaaay more storage capacity, way better speeds and way smaller bundle sizes.