Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add linux dynamic library "lib" prefix #306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iacore
Copy link

@iacore iacore commented Jan 14, 2024

No description provided.

@AlbertShown
Copy link
Contributor

LGTM.
All wrappers that use a downloader script/code should update the lib name for Linux after merging this PR.

@ttytm
Copy link
Member

ttytm commented May 26, 2024

In case this change is made, wouldn't it be most consistent make a general update, instead just the dyn out on linux?

WEBUI_OUT_LIB_NAME = webui-2

@iacore
Copy link
Author

iacore commented May 27, 2024

In case this change is made, wouldn't it be most consistent make a general update, instead just the dyn out on linux?

WEBUI_OUT_LIB_NAME = webui-2

That is not what this is about. Only the Linux .so output is broken, I think.

Also, did someone forget to merge this? :?

@ttytm
Copy link
Member

ttytm commented May 27, 2024

That is not what this is about. Only the Linux .so output is broken, I think.

Also, did someone forget to merge this? :?

Well it is about that. And I wanted to resolves this question about making a more general update to ensure consistency before merging the PR...

E.g. with your current changes it will stay without lib on macos. Ref.:

webui/GNUmakefile

Lines 58 to 61 in b3c8f78

# MacOS
PLATFORM := macos
CC = clang
LIB_DYN_OUT := $(WEBUI_OUT_LIB_NAME).dylib

@ttytm
Copy link
Member

ttytm commented May 27, 2024

I don't think it was broken either, it was just the name chosen so far. We can look into platform naming conventions get to the best possible state when making a breaking change like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants