Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose _webui_find_the_best_browser as webui_get_best_browser #326

Merged
merged 1 commit into from
May 31, 2024
Merged

Expose _webui_find_the_best_browser as webui_get_best_browser #326

merged 1 commit into from
May 31, 2024

Conversation

SpikeHD
Copy link
Contributor

@SpikeHD SpikeHD commented Feb 13, 2024

Changes

  • Wraps an exported function webui_get_best_browser around the internal _webui_find_the_best_browser.
  • Adds the function to the C++ class

Resolves #325

@SpikeHD SpikeHD changed the title Expose webui_get_best_browser Expose _webui_find_the_best_browser as webui_get_best_browser Feb 13, 2024
@hassandraga hassandraga merged commit 817cc60 into webui-dev:main May 31, 2024
11 checks passed
@hassandraga
Copy link
Member

Thank you @SpikeHD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassandraga hassandraga hassandraga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Expose _webui_find_best_browser
2 participants
@SpikeHD @hassandraga