Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ events are now enum instead of const static int #351

Merged
merged 1 commit into from
May 31, 2024

Conversation

GiuseppeCesarano
Copy link
Contributor

This pr is not intended to change API compatibility, in fact the C++ example serve_a_folder can be compiled without changes, but a larger discussion should be held about the status of enums for example:

@AlbertShown
Copy link
Contributor

No breaking changes, but a good improvement, thank you @GiuseppeCesarano 👍

I personally likes enum because it can enable certain compile-time checks and warnings over constants plain integers, also debuggers can show the names instead of integer.

@hassandraga hassandraga merged commit 6fe3549 into webui-dev:main May 31, 2024
11 checks passed
@hassandraga
Copy link
Member

Thank you @GiuseppeCesarano.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants