Build: many GitHub annotations #6316
Conversation
This marks compiler errors clearly on github. gcc and clang seem to report problems in the same way.
Use gcc matcher as the format is the same. This marks errors clearly on github.
This marks compiler errors clearly on github.
I guessed with 0.2 it would automatically update to 0.2.1, but this is wrong.
There was a problem hiding this comment.
On Mon Jan 15 13:47:04 CET 2024, Tóth András (tothxa) commented.
| @@ -18,6 +18,8 @@ jobs: | |||
| uses: actions/checkout@v3 | |||
| - name: Installing dependencies | |||
| run: sh ./.github/scripts/install_deps.sh | |||
| - name: show compiler failures clearly on github | |||
| uses: ammaraskar/gcc-problem-matcher@0.2.0 | |||
There was a problem hiding this comment.
On Mon Jan 15 13:47:04 CET 2024, Tóth András (tothxa) wrote:
-1 for another unofficial action.
|
And another -1 if it's responsible for this: Also, could you please concentrate on your PRs that are targeted for v1.2 until we can freeze, instead of opening new ones? |
|
|
|
For clarification: The idea is OK in theory, but it's certainly bad execution if lines causing failures get spammed like this. And it's not even the 16 failures in our 16 matrix configurations, but more instances with the same matrix config. Also annotations on github are of little use for users on codeberg. |
bunnybot
added
ci:success
bunnybot
added
ci:success
Type of change
Enhancement of testsuite
Issue(s) closed
Fixes -
New behavior
Compiler errors and similar messages are marked clearly on GitHub.
How it works
The marking of the failure is done with github problem matchers.
A README.md about it is included in another pr (only in one to avoid merge conflicts), see: https://github.com/SimonHeimberg/widelands/tree/build_codecheck_improve/.github/problem_matchers