-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update add-on i18n for tinygettext #6453
Conversation
Assigned to Nordfriese |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM however needs testing see inline comment
g_fs->fs_unlink(mo); | ||
} | ||
if (g_fs->file_exists(new_locale_path)) { | ||
g_fs->fs_unlink(new_locale_path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we had problems in the past and still have imhgo with unlink on windows. Is there an addon with which I could test this from the server.
Mirrored from Codeberg You can use the Alpha server |
ok. so to properly test this I need to use the alpha, and download the frisians Ultra, afterwads I need to change the version manually and redownload it to have the files in question existing. correct? |
Mirrored from Codeberg Yes, just edit the |
ok der File Handle und unlink funktioniert auch unter Windows. |
vielleicht nur ne Randnotiz aber ich hatte jede Menge could not translate: (0 oder 1) messages im log. |
@bunnybot update |
…ordfriese/widelands/tinygettext-addons
Successfully updated the branch as requested in comment 2120367618 at commit 57e3dd3. |
Mirrored from Codeberg Counterpart is deployed on the live system (and alpha serves the website maps integration PR again). <@>bunnybot merge The "could not translate" messages are in master too now, but only with IMHO we should just keep the MO files around for now, so if users switch between v1.2 and master they don't get their translations autodeleted every time. It's just a few kB so it doesn't really matter much, but after v1.3 we could maybe add a simple cleanup scanner. |
…6453) Co-authored-by: Benedikt Straub <benedikt-straub@web.de> Co-committed-by: Benedikt Straub <benedikt-straub@web.de>
I had exactly the same in mind, but just wanted to be sure that we do not forget planning for it. |
Mirrored from Codeberg
Created on Fri May 17 13:15:06 CEST 2024 by Benedikt Straub (Nordfriese)
Type of change
Follow-up to #6411
Counterpart to wl/wl_addons_server#88 (currently served on alpha)
New behavior
We now get add-on translations as PO files from the server. We can now have a cleaner directory structure, and since we control our own cache now, we no longer need the hack of adding the i18n version to the filename.
Possible regressions
Add-on translations, and add-on translation upgrades