Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Matching Request method with isOneOf & isNoneOf #2234

Open
wants to merge 110 commits into
base: master
Choose a base branch
from
Open

Feature Request: Matching Request method with isOneOf & isNoneOf #2234

wants to merge 110 commits into from

Conversation

pks-1981
Copy link
Contributor

@pks-1981 pks-1981 commented Jun 25, 2023 •
edited

Feature Request: Matching Request method with isOneOf & isNoneOf.

Adding the ability to specify a list of request methods.

#1434
Based on #1734

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@pks-1981 pks-1981 marked this pull request as draft June 25, 2023 16:49
@pks-1981 pks-1981 marked this pull request as ready for review June 25, 2023 16:58
@pks-1981
Copy link
Contributor Author

@tomakehurst
I will try to make a normal description as soon as possible.

But waiting review)))

@pks-1981
Copy link
Contributor Author

@tomakehurst
Hello.
May be only methods?
+ " "method" : "GET", \n"
+ " "methods" : ["GET"] \n"

Kirill Peshin added 2 commits June 27, 2023 07:17
@pks-1981
Copy link
Contributor Author

@timtebeek @oleg-nenashev
If you don't mind take a look...
For some advice)))

@pks-1981 pks-1981 marked this pull request as draft June 28, 2023 13:42
Kirill Peshin added 3 commits July 5, 2023 10:58
Merge branch 'master' into 1434
4c0793b
Merge branch 'master' into 1434
033c771 
# Conflicts:
#	src/main/java/com/github/tomakehurst/wiremock/client/BasicMappingBuilder.java
#	src/main/java/com/github/tomakehurst/wiremock/matching/MatchResult.java
#	src/main/java/com/github/tomakehurst/wiremock/matching/RequestPattern.java
#	src/main/java/com/github/tomakehurst/wiremock/matching/RequestPatternBuilder.java
#	src/test/java/com/github/tomakehurst/wiremock/matching/RequestPatternBuilderTest.java
update
3526fc5
oleg-nenashev
oleg-nenashev reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far looks good. A bit more of work is needed to land it but I think it could be integrated soon

Kirill Peshin added 2 commits July 13, 2023 08:47
Merge branch 'master' into 1434
0481bc8 
# Conflicts:
#	src/main/java/com/github/tomakehurst/wiremock/matching/RequestPatternBuilder.java
update
df78881
@pks-1981
Copy link
Contributor Author

So far looks good. A bit more of work is needed to land it but I think it could be integrated soon

unfortunately i have no time and ideas, right now
So i am be glad if someone help me)

@pks-1981
Copy link
Contributor Author

@tomakehurst
Unfortunately I can't figure out how to implement DiffLine
I need help

@pks-1981 pks-1981 marked this pull request as ready for review August 10, 2023 04:45
@pks-1981 pks-1981 requested a review from a team as a code owner August 10, 2023 04:45
Kirill Peshin added 11 commits February 25, 2024 22:01
Merge branch 'master' into 1434
de14204
Merge branch 'master' into 1434
8924c3a
Update
9b12eae
Merge branch 'master' into 1434
f9d36a2 
# Conflicts:
#	src/main/java/com/github/tomakehurst/wiremock/matching/RequestPattern.java
#	src/main/java/com/github/tomakehurst/wiremock/verification/diff/Diff.java
#	src/main/java/com/github/tomakehurst/wiremock/verification/diff/DiffLine.java
#	src/test/java/com/github/tomakehurst/wiremock/verification/diff/PlainTextDiffRendererTest.java
Update
f914b3f
Update
cab72a7
Merge branch 'master' into 1434
89860d7
Merge branch 'master' into 1434
c6dd2b6
Merge branch 'master' into 1434
1a6f52c
Merge branch 'master' into 1434
6cf54da 
# Conflicts:
#	src/main/java/com/github/tomakehurst/wiremock/matching/RequestPattern.java
Update
fcef205
@pks-1981
Copy link
Contributor Author

@tomakehurst hello)
Plz look at my updated MR

Kirill Peshin added 13 commits March 29, 2024 07:13
Merge branch 'master' into 1434
c7de4f7
Update
ee1e153
Merge branch 'master' into 1434
d344210
Merge branch 'master' into 1434
ad0d3e3
Merge branch 'refs/heads/master' into 1434
18b58e7 
# Conflicts:
#	src/test/java/com/github/tomakehurst/wiremock/AdminApiTest.java
#	src/test/java/com/github/tomakehurst/wiremock/StubbingAcceptanceTest.java
#	src/test/java/com/github/tomakehurst/wiremock/VerificationAcceptanceTest.java
#	src/test/java/com/github/tomakehurst/wiremock/matching/RequestPatternTest.java
Update
08c11e6
Update
04bc93a
Merge branch 'refs/heads/master' into 1434
e4b8256
Merge branch 'refs/heads/master' into 1434
7f0c827
Merge branch 'refs/heads/master' into 1434
fca95c7
Merge branch 'refs/heads/master' into 1434
9013c69
Merge branch 'refs/heads/master' into 1434
76fbf31 
# Conflicts:
#	src/test/java/com/github/tomakehurst/wiremock/StubbingAcceptanceTest.java
update
19623b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev

@tomakehurst tomakehurst Awaiting requested review from tomakehurst

@AlexOblizin AlexOblizin Awaiting requested review from AlexOblizin

Assignees

@tomakehurst tomakehurst

Labels
enhancement needs-tom Tom's Train Project :)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pks-1981 @tomakehurst @oleg-nenashev @AlexOblizin