Record&Replay - Support for multipart/related without Content-Disposition headers #2264

hladysz · 2023-07-12T15:03:37Z

Support for multipart/related without Content-Disposition headers - recording and replaying

References

Multipart requests not properly recorded and matched #2260

Submitter checklist

The PR request is well described and justified, including the body and the references
The PR title represents the desired changelog entry
The repository's code style is followed (see the contributing guide)
Test coverage that demonstrates that the change works as expected
For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

…n headers - recording and replaying

oleg-nenashev

Sounds about right from the code. I haven't tested it, but the potential impact is isolated enough

oleg-nenashev · 2023-07-22T06:49:28Z

src/test/java/com/github/tomakehurst/wiremock/stubbing/StubMappingJsonRecorderTest.java

@@ -421,7 +421,7 @@ public void decompressesGzippedResponseBodyAndRemovesContentEncodingHeader() {
          + "		\"url\": \"/multipart/content\",							\n"
          + "		\"multipartPatterns\" : [ {									\n"
          + "			\"name\" : \"binaryFile\",								\n"
-          + "			\"matchingType\" : \"ALL\",								\n"
+          + "			\"matchingType\" : \"ANY\",								\n"


Is this change really needed?

Yes, there's an example of mis-match in src/test/java/com/github/tomakehurst/wiremock/matching/RequestPatternTest.java#doesNotMatchExactlyWhenManyMultipartPatternsSupposeToMatchAllDistinctParts() that test is using the default value which is to match ALL parts.

It was changed in the recorder to match ANY part in src/main/java/com/github/tomakehurst/wiremock/stubbing/StubMappingJsonRecorder.java:102

tomakehurst · 2023-07-22T16:54:40Z

This fixes the (now deprecated) legacy recorder, which we'll be removing soon.

Does this issue affect the current recorder, and if so could we fix it there instead?

hladysz · 2023-07-22T18:58:21Z

This fixes the (now deprecated) legacy recorder, which we'll be removing soon.

Does this issue affect the current recorder, and if so could we fix it there instead?

Thanks. Where can I find the new and improved recorder?

tomakehurst · 2023-07-24T07:29:26Z

com.github.tomakehurst.wiremock.recording.Recorder is the place to start for the new one

hladysz · 2023-07-24T10:31:12Z

com.github.tomakehurst.wiremock.recording.Recorder is the place to start for the new one

looking.

hladysz · 2023-07-24T15:42:07Z

com.github.tomakehurst.wiremock.recording.Recorder is the place to start for the new one

This one can't be executed in a standalone version, can it?

hladysz · 2023-07-24T16:08:08Z

com.github.tomakehurst.wiremock.recording.Recorder is the place to start for the new one

If this is what I think it is (

wiremock/src/main/java/com/github/tomakehurst/wiremock/recording/RequestBodyAutomaticPatternFactory.java

Line 73 in 5f0677f

} else if (mimeType.equals("multipart/form-data")) {

) then it would be a lot of work to support multipart in there. Can I pair with someone if that needs to be done as a part of this fix?

hladysz · 2023-07-24T17:02:41Z

Unless we can copy the same logic
from here:

wiremock/src/main/java/com/github/tomakehurst/wiremock/stubbing/StubMappingJsonRecorder.java

Line 86 in 5f0677f

if (request.isMultipart() && request.getParts() != null) {

into here:

wiremock/src/main/java/com/github/tomakehurst/wiremock/recording/RequestPatternTransformer.java

Line 58 in 5f0677f

if (bodyPatternFactory != null && body != null && body.length > 0) {

hladysz · 2023-07-24T17:04:42Z

Not too sure what's the significance of this one:

wiremock/src/main/java/com/github/tomakehurst/wiremock/recording/RequestBodyAutomaticPatternFactory.java

Line 73 in 5f0677f

} else if (mimeType.equals("multipart/form-data")) {

tomakehurst · 2023-07-25T07:59:49Z

com.github.tomakehurst.wiremock.recording.Recorder is the place to start for the new one

This one can't be executed in a standalone version, can it?

Yes it can, but you start it via an API call or from the recorder UI page, rather than via the CLI.

hladysz · 2023-07-25T08:39:56Z

com.github.tomakehurst.wiremock.recording.Recorder is the place to start for the new one

This one can't be executed in a standalone version, can it?

Yes it can, but you start it via an API call or from the recorder UI page, rather than via the CLI.

Thank you for your response.

oleg-nenashev · 2023-08-28T08:06:02Z

@hladysz @tomakehurst I guess this PR is a no-go since the old recorder is now deprecated, right?

hladysz · 2023-08-28T20:27:41Z

I've contributed my time fixing the bug, but would need some help fixing the architecture. I think at the moment the other recorder is missing more than the functionality I've fixed. Looks like it wasn't kept up to date with the old one for a while now. pon., 28 sie 2023 o 09:06 Oleg Nenashev ***@***.***> napisał(a):

…

@hladysz <https://github.com/hladysz> @tomakehurst <https://github.com/tomakehurst> I guess this PR is a no-go since the old recorder is now deprecated, right? — Reply to this email directly, view it on GitHub <#2264 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADIING2ZQL5GUGSY32VSFTXXRGPNANCNFSM6AAAAAA2HUCR4A> . You are receiving this because you were mentioned.Message ID: ***@***.***>

oleg-nenashev · 2023-09-07T12:13:45Z

Thanks @hladysz . I will review it with the team

[ISSUE-2260] Support for multipart/related without Content-Dispositio…

7dba448

…n headers - recording and replaying

hladysz requested a review from a team as a code owner July 12, 2023 15:03

hladysz mentioned this pull request Jul 12, 2023

Multipart requests not properly recorded and matched #2260

Open

oleg-nenashev changed the title ~~[ISSUE-2260] Support for multipart/related without Content-Dispositio…~~ Record&Replay - Support for multipart/related without Content-Disposition headers Jul 22, 2023

oleg-nenashev added the bug label Jul 22, 2023

oleg-nenashev approved these changes Jul 22, 2023

View reviewed changes

oleg-nenashev requested a review from tomakehurst September 7, 2023 12:12

oleg-nenashev added the needs-tom Tom's Train Project :) label Sep 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Record&Replay - Support for multipart/related without Content-Disposition headers #2264

Record&Replay - Support for multipart/related without Content-Disposition headers #2264

hladysz commented Jul 12, 2023 •

edited

oleg-nenashev left a comment

oleg-nenashev Jul 22, 2023

hladysz Jul 22, 2023

hladysz Jul 22, 2023 •

edited

tomakehurst commented Jul 22, 2023

hladysz commented Jul 22, 2023

tomakehurst commented Jul 24, 2023

hladysz commented Jul 24, 2023

hladysz commented Jul 24, 2023

hladysz commented Jul 24, 2023

hladysz commented Jul 24, 2023 •

edited

hladysz commented Jul 24, 2023

tomakehurst commented Jul 25, 2023

hladysz commented Jul 25, 2023

oleg-nenashev commented Aug 28, 2023

hladysz commented Aug 28, 2023 via email

oleg-nenashev commented Sep 7, 2023

Record&Replay - Support for multipart/related without Content-Disposition headers #2264

Are you sure you want to change the base?

Record&Replay - Support for multipart/related without Content-Disposition headers #2264

Conversation

hladysz commented Jul 12, 2023 • edited

References

Submitter checklist

oleg-nenashev left a comment

Choose a reason for hiding this comment

oleg-nenashev Jul 22, 2023

Choose a reason for hiding this comment

hladysz Jul 22, 2023

Choose a reason for hiding this comment

hladysz Jul 22, 2023 • edited

Choose a reason for hiding this comment

tomakehurst commented Jul 22, 2023

hladysz commented Jul 22, 2023

tomakehurst commented Jul 24, 2023

hladysz commented Jul 24, 2023

hladysz commented Jul 24, 2023

hladysz commented Jul 24, 2023

hladysz commented Jul 24, 2023 • edited

hladysz commented Jul 24, 2023

tomakehurst commented Jul 25, 2023

hladysz commented Jul 25, 2023

oleg-nenashev commented Aug 28, 2023

hladysz commented Aug 28, 2023 via email

oleg-nenashev commented Sep 7, 2023

hladysz commented Jul 12, 2023 •

edited

hladysz Jul 22, 2023 •

edited

hladysz commented Jul 24, 2023 •

edited