Refactor: remove pointless generics #2379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<P>` serves no purpose in these methods beyond Object, it doesn't affect the accepted types or the return type of the method.
Mahoney
force-pushed
the
remove-pointless-generics
branch
from
d62182d
to
49bb3f1
Compare
|
@oleg-nenashev I imagine this is binary compatible, as generics are really just a compile time thing? |
There was a problem hiding this comment.
@Mahoney I would prefer to avoid it as long as the change is not source-compatible.. It may also, in theory, lead to unexpected overrides in API consumer classes https://wiki.eclipse.org/Evolving_Java-based_APIs_2#Turning_non-generic_types_and_methods_into_generic_ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<P>serves no purpose in these methods beyond Object, it doesn'taffect the accepted types or the return type of the method.
References
N/A
Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java