Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add error message for svg without dimensions #10924

Merged
merged 9 commits into from May 16, 2024
Merged

add error message for svg without dimensions #10924

merged 9 commits into from May 16, 2024

Conversation

Its-Just-Nans
Copy link
Contributor

May fix #10913

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 1, 2024 •
edited

🦋 Changeset detected

Latest commit: c37f29b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 1, 2024
@Princesseuh
Copy link
Member

I would suggested contributing those changes upstream in https://github.com/image-size/image-size, as opposed to modifying the vendored version we have.

@Its-Just-Nans Its-Just-Nans mentioned this pull request May 1, 2024
Open
@Its-Just-Nans
Copy link
Contributor Author

I would suggested contributing those changes upstream in https://github.com/image-size/image-size, as opposed to modifying the vendored version we have.

Done. https://github.com/image-size/image-size/pull/404/files

but it's not fixing the current astro bug with svg

@Its-Just-Nans Its-Just-Nans changed the title add svg detection add error message for svg without dimensions May 1, 2024
@Its-Just-Nans
Copy link
Contributor Author

Okay the major problem was that lookup() was throwing an error without a good explanation.

This PR fixes that

@Its-Just-Nans Its-Just-Nans mentioned this pull request May 1, 2024
Closed
@Its-Just-Nans
Copy link
Contributor Author

Its-Just-Nans commented May 1, 2024 •
edited

@Princesseuh
This PR now only modify the errors messages!

@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label May 1, 2024
github-actions[bot]
github-actions bot previously requested changes May 1, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

matthewp
matthewp approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Its-Just-Nans
Its-Just-Nans commented May 7, 2024
View reviewed changes
Copy link
Contributor Author

@Its-Just-Nans Its-Just-Nans left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like @github-actions[bot] is blocking the merge

@bluwy bluwy removed the semver: minor Change triggers a `minor` release label May 9, 2024
@Princesseuh Princesseuh merged commit 3a0c02a into withastro:main May 16, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 16, 2024
Merged
@Its-Just-Nans Its-Just-Nans deleted the fix-svg-detection branch May 16, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

@ematipico ematipico ematipico approved these changes

@github-actions github-actions[bot] github-actions left review comments

@Princesseuh Princesseuh Awaiting requested review from Princesseuh

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Astro glob throw unsupported files for svg
5 participants
@Its-Just-Nans @Princesseuh @matthewp @ematipico @bluwy