Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generator.ts to allow %23 (#) in dynamic urls #10965

Merged
merged 11 commits into from
May 16, 2024
5 changes: 5 additions & 0 deletions .changeset/mean-geckos-sell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"astro": minor
Elias-Chairi marked this conversation as resolved.
Show resolved Hide resolved
---

Update generator.ts to allow %23 (#) in dynamic urls
2 changes: 1 addition & 1 deletion packages/astro/src/core/routing/manifest/generator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function getRouteGenerator(
if (addTrailingSlash === 'always' && segments.length) {
trailing = '/';
}
const toPath = compile(template + trailing);
const toPath = compile(template + trailing, { delimiter: "/?" });
return (params: object): string => {
const path = toPath(params);

Expand Down